Fix the path to the megazord symbols when uploading #6389
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6389 +/- ##
=======================================
Coverage 49.30% 49.30%
=======================================
Files 146 146
Lines 13708 13708
=======================================
Hits 6759 6759
Misses 6949 6949
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The symbols server expect a specific layout for the archive, and fetch-content extracts our symbols archive one directory deeper than I expected.
jcristau
force-pushed
the
upload-symbols-debug
branch
2 times, most recently
from
f6dddab
to
9e5015a
Compare
jcristau
changed the title
| - name: project/application-services/symbols-token | ||
| key: token | ||
| path: .symbols_upload_token | ||
| default: [] |
There was a problem hiding this comment.
Should this be removed? I'm wondering if you removed it for your try build and forget to put it back in.
There was a problem hiding this comment.
This is a cleanup I noticed while looking at this; since module-build doesn't upload symbols, it doesn't need access to the symbols.m.o upload token, only upload-symbols does.
There was a problem hiding this comment.
AFAICT this was unused since commit 448dddd.
There was a problem hiding this comment.
Ahh, I see. That makes total sense.
|
@mergify backport release-v131 |
✅ Backports have been created
|
fetch-content extracts our symbols archive one directory deeper than I expected, so this fixes commit 37a76bb's fix.
It also adds some more debugging info to the upload_symbols script in case of failure, and removes upload-symbols-related config from the module-build tasks.