Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the path to the megazord symbols when uploading #6389

Merged
merged 3 commits into from
Sep 20, 2024
+2 −15
Merged

Fix the path to the megazord symbols when uploading #6389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df4bcd6
ci: module-build doesn't need a token to upload symbols anymore
jcristau Sep 20, 2024
fb627c6
upload_symbols: print the response in case of error
jcristau Sep 20, 2024
9e5015a
ci: fix upload-symbols harder
jcristau Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions automation/symbols-generation/upload_symbols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ def upload_symbols(zip_file, token_file):
return True

print("Upload symbols failed: {0}".format(r), file=sys.stderr)
print(r.text, file=sys.stderr)
return False

def main():
Expand Down
14 changes: 0 additions & 14 deletions taskcluster/kinds/module-build/kind.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ loader: app_services_taskgraph.loader.build_config:loader

transforms:
- app_services_taskgraph.transforms.worker:transforms
- app_services_taskgraph.transforms.secrets:transforms
- app_services_taskgraph.transforms.module_build:transforms
- taskgraph.transforms.run:transforms
- taskgraph.transforms.task:transforms
Expand Down Expand Up @@ -38,19 +37,6 @@ task-defaults:
- ':{module_name}:assembleRelease'
- ':{module_name}:publish'
- ':{module_name}:checkMavenArtifacts'
dummy-secrets:
by-level:
'3': []
default:
- content: "faketoken"
path: .symbols_upload_token
secrets:
by-level:
'3':
- name: project/application-services/symbols-token
key: token
path: .symbols_upload_token
default: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed? I'm wondering if you removed it for your try build and forget to put it back in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cleanup I noticed while looking at this; since module-build doesn't upload symbols, it doesn't need access to the symbols.m.o upload token, only upload-symbols does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this was unused since commit 448dddd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I see. That makes total sense.

using: gradlew
use-caches: true

Expand Down
2 changes: 1 addition & 1 deletion taskcluster/kinds/upload-symbols/kind.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ tasks:
run:
using: run-commands
commands:
- [automation/upload_android_symbols.sh, /builds/worker/fetches/crashreporter-symbols]
- [automation/upload_android_symbols.sh, /builds/worker/fetches/crashreporter-symbols/crashreporter-symbols]
dummy-secrets:
by-level:
'3': []
Expand Down