Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the path to the megazord symbols when uploading (backport #6389) #6390

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 20, 2024

fetch-content extracts our symbols archive one directory deeper than I expected, so this fixes commit 37a76bb's fix.

It also adds some more debugging info to the upload_symbols script in case of failure, and removes upload-symbols-related config from the module-build tasks.


This is an automatic backport of pull request #6389 done by Mergify.

The symbols server expect a specific layout for the archive, and
fetch-content extracts our symbols archive one directory deeper than I
expected.

(cherry picked from commit ed20db0)
@rvandermeulen rvandermeulen enabled auto-merge (rebase) September 20, 2024 19:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.65%. Comparing base (3ee5714) to head (72f1d6b).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-v131    #6390   +/-   ##
=============================================
  Coverage         22.65%   22.65%           
=============================================
  Files               327      327           
  Lines             29837    29837           
=============================================
  Hits               6759     6759           
  Misses            23078    23078           
Flag Coverage Δ
22.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rvandermeulen rvandermeulen merged commit afbb6c6 into release-v131 Sep 20, 2024
14 of 15 checks passed
@rvandermeulen rvandermeulen deleted the mergify/bp/release-v131/pr-6389 branch September 20, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants