✨ Enable new UI tier0 tests #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
reenable-ui-tier0-tests
branch
from
ee3cbea
to
a18bbec
Compare
abrugaro
approved these changes
Oct 23, 2023
.github/workflows/global-ci.yml
Outdated
| @@ -30,7 +30,7 @@ on: | |||
| type: boolean | |||
| required: false | |||
| # TODO: Swap to true once these are passing consistently | |||
There was a problem hiding this comment.
This one, and the other similar comments can be already removed in this PR.
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
reenable-ui-tier0-tests
branch
from
b83aea2
to
cc46c43
Compare
aufi
reviewed
Oct 26, 2023
.github/workflows/ci.yaml
Outdated
| @@ -5,3 +5,5 @@ on: ["push", "pull_request"] | |||
| jobs: | |||
| ci: | |||
| uses: ./.github/workflows/global-ci.yml | |||
| with: | |||
| ui_tests_ref: 32c44ba1f457f0e87204787b4c81bd6cf1d211fb | |||
There was a problem hiding this comment.
I might miss something, but isn't it better use branch names instead of commit tags to allow test fixes/updates without need to change ui_tests_ref in this CI repo?
There was a problem hiding this comment.
for sure, this was just to make sure it picked up the most recent PR. I didn't sign this commit to ensure that this PR won't merge whie it's in it
fabianvf
force-pushed
the
reenable-ui-tier0-tests
branch
from
cc46c43
to
26973aa
Compare
fabianvf
force-pushed
the
reenable-ui-tier0-tests
branch
from
b3a3cd6
to
210ea5a
Compare
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
reenable-ui-tier0-tests
branch
from
210ea5a
to
3325467
Compare
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
reenable-ui-tier0-tests
branch
from
353a289
to
3eb2d28
Compare
djzager
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Tests PR: 55