Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enable new UI tier0 tests #19

Merged
merged 4 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 24 additions & 31 deletions .github/workflows/global-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ on:
A flag that determines whether the UI tests should be run or not
type: boolean
required: false
# TODO: Swap to true once these are passing consistently
default: false
default: true
api_tests_ref:
description: |
The branch or PR of the go-konveyor-tests repository to clone.
Expand Down Expand Up @@ -82,9 +81,8 @@ on:
description: |
A flag that determines whether the UI tests should be run or not
type: boolean
required: false
# TODO: Swap to true once these are passing consistently
default: false
required: true
default: true
api_tests_ref:
description: |
The branch or PR of the go-konveyor-tests repository to clone.
Expand Down Expand Up @@ -117,7 +115,7 @@ jobs:
steps:
- name: Extract pull request number from inputs or PR description
run: |
PULL_REQUEST_NUMBER=$(echo "${{ github.event.pull_request.body }}" | grep -oP '[A|a][P|p][I|i] [T|t]ests [P|p][R|r]: \K\d+' || true)
PULL_REQUEST_NUMBER=$(echo "${{ github.event.pull_request.body }}" | grep -oP '[A|a][P|p][I|i] [T|t]ests [P|p][R|r]:\s*\K\d+' || true)
if [ -z "$PULL_REQUEST_NUMBER" ]; then
echo "GOLANG_TESTS_REF=${{ inputs.api_tests_ref }}" >>$GITHUB_ENV
else
Expand Down Expand Up @@ -191,9 +189,8 @@ jobs:
strategy:
fail-fast: false
matrix:
# TODO: Support cypress-split in main tackle-ui-test project
# split: [0, 1, 2, 3, 4, 5, 6, 7, 8]
tier: [tier1, tier2, tier3]
# TODO enable customizing the number of tiers run for nightlies
tier: [tier0] #, tier1, tier2, tier3]
steps:

- name: Extract pull request number from inputs or PR description
Expand Down Expand Up @@ -238,16 +235,15 @@ jobs:
- name: install konveyor
uses: konveyor/tackle2-operator/.github/actions/install-tackle@main
with:
# TODO need to set the tackle-operator image once supported
# tackle-operator-image: quay.io/konveyor/tackle2-operator:${{ inputs.tag }}
tackle-hub-image: "quay.io/konveyor/tackle2-hub:${{ inputs.tag }}"
tackle-pathfinder-image: "quay.io/konveyor/tackle-pathfinder:${{ inputs.tag != 'latest' && inputs.tag || '1.3.0-native' }}"
tackle-ui-image: "quay.io/konveyor/tackle2-ui:${{ inputs.tag }}"
tackle-addon-admin-image: "quay.io/konveyor/tackle2-addon:${{ inputs.tag }}"
tackle-addon-windup-image: "quay.io/konveyor/tackle2-addon-windup:${{ inputs.tag }}"
tackle-image-pull-policy: IfNotPresent
tackle-windup-container-memory: 0
tackle-windup-container-cpu: 0
operator-bundle-image: "quay.io/konveyor/tackle2-operator-bundle:${{ inputs.tag }}"
hub-image: "quay.io/konveyor/tackle2-hub:${{ inputs.tag }}"
pathfinder-image: "quay.io/konveyor/tackle-pathfinder:${{ inputs.tag != 'latest' && inputs.tag || '1.3.0-native' }}"
ui-image: "quay.io/konveyor/tackle2-ui:${{ inputs.tag }}"
addon-admin-image: "quay.io/konveyor/tackle2-addon:${{ inputs.tag }}"
addon-analyzer-image: "quay.io/konveyor/tackle2-addon-analyzer:${{ inputs.tag }}"
image-pull-policy: IfNotPresent
analyzer-container-memory: 0
analyzer-container-cpu: 0
# end DRY

- name: Wait for Ingress and expose UI service
Expand All @@ -265,15 +261,15 @@ jobs:
echo $external_ip;
echo "UI_URL=https://$(minikube ip)" >>$GITHUB_ENV

- name: Run login tests
uses: cypress-io/github-action@v5
env:
CYPRESS_user: admin
CYPRESS_pass: password
CYPRESS_tackleUrl: "${{ env.UI_URL }}"
with:
working-directory: tackle-ui-tests
spec: "cypress/e2e/tests/login.test.ts"
# - name: Run login tests
# uses: cypress-io/github-action@v5
# env:
# CYPRESS_user: admin
# CYPRESS_pass: password
# CYPRESS_tackleUrl: "${{ env.UI_URL }}"
# with:
# working-directory: tackle-ui-tests
# spec: "cypress/e2e/tests/login.test.ts"

- name: Run UI tests
uses: cypress-io/github-action@v5
Expand All @@ -285,9 +281,6 @@ jobs:
CYPRESS_git_user: "fakeuser"
CYPRESS_git_password: "${{ secrets.GITHUB_TOKEN }}"
CYPRESS_git_key: "${{ secrets.GITHUB_TOKEN }}"
# TODO: Support cypress-split in main tackle-ui-test project
# CYPRESS_split: "${{ strategy.job-total }}"
# CYPRESS_splitIndex: "${{ strategy.job-index }}"
with:
working-directory: tackle-ui-tests
spec: "**/*.test.ts"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ jobs:
run_api_tests: true
ui_tests_ref: main
# Disabled while we wait for stability
run_ui_tests: false
run_ui_tests: true
2 changes: 1 addition & 1 deletion .github/workflows/nightly-main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ jobs:
run_api_tests: true
ui_tests_ref: main
# Disabled while we wait for stability
run_ui_tests: false
run_ui_tests: true
Loading