Skip to content

Commit

Permalink
Fix input names
Browse files Browse the repository at this point in the history
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
  • Loading branch information
fabianvf committed Oct 24, 2023
1 parent a18bbec commit 26973aa
Showing 1 changed file with 11 additions and 18 deletions.
29 changes: 11 additions & 18 deletions .github/workflows/global-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ on:
A flag that determines whether the UI tests should be run or not
type: boolean
required: false
# TODO: Swap to true once these are passing consistently
default: true
api_tests_ref:
description: |
Expand Down Expand Up @@ -83,8 +82,7 @@ on:
A flag that determines whether the UI tests should be run or not
type: boolean
required: true
# TODO: Swap to true once these are passing consistently
default: false
default: true
api_tests_ref:
description: |
The branch or PR of the go-konveyor-tests repository to clone.
Expand Down Expand Up @@ -191,8 +189,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# TODO: Support cypress-split in main tackle-ui-test project
# split: [0, 1, 2, 3, 4, 5, 6, 7, 8]
# TODO enable customizing the number of tiers run for nightlies
tier: [tier0] #, tier1, tier2, tier3]
steps:

Expand Down Expand Up @@ -238,16 +235,15 @@ jobs:
- name: install konveyor
uses: konveyor/tackle2-operator/.github/actions/install-tackle@main
with:
# TODO need to set the tackle-operator image once supported
# tackle-operator-image: quay.io/konveyor/tackle2-operator:${{ inputs.tag }}
tackle-hub-image: "quay.io/konveyor/tackle2-hub:${{ inputs.tag }}"
tackle-pathfinder-image: "quay.io/konveyor/tackle-pathfinder:${{ inputs.tag != 'latest' && inputs.tag || '1.3.0-native' }}"
tackle-ui-image: "quay.io/konveyor/tackle2-ui:${{ inputs.tag }}"
tackle-addon-admin-image: "quay.io/konveyor/tackle2-addon:${{ inputs.tag }}"
tackle-addon-windup-image: "quay.io/konveyor/tackle2-addon-windup:${{ inputs.tag }}"
tackle-image-pull-policy: IfNotPresent
tackle-windup-container-memory: 0
tackle-windup-container-cpu: 0
operator-bundle-image: "quay.io/konveyor/tackle2-operator-bundle:${{ inputs.tag }}"
hub-image: "quay.io/konveyor/tackle2-hub:${{ inputs.tag }}"
pathfinder-image: "quay.io/konveyor/tackle-pathfinder:${{ inputs.tag != 'latest' && inputs.tag || '1.3.0-native' }}"
ui-image: "quay.io/konveyor/tackle2-ui:${{ inputs.tag }}"
addon-admin-image: "quay.io/konveyor/tackle2-addon:${{ inputs.tag }}"
addon-analyzer-image: "quay.io/konveyor/tackle2-addon-analyzer:${{ inputs.tag }}"
image-pull-policy: IfNotPresent
analyzer-container-memory: 0
analyzer-container-cpu: 0
# end DRY

- name: Wait for Ingress and expose UI service
Expand Down Expand Up @@ -285,9 +281,6 @@ jobs:
CYPRESS_git_user: "fakeuser"
CYPRESS_git_password: "${{ secrets.GITHUB_TOKEN }}"
CYPRESS_git_key: "${{ secrets.GITHUB_TOKEN }}"
# TODO: Support cypress-split in main tackle-ui-test project
# CYPRESS_split: "${{ strategy.job-total }}"
# CYPRESS_splitIndex: "${{ strategy.job-index }}"
with:
working-directory: tackle-ui-tests
spec: "**/*.test.ts"
Expand Down

0 comments on commit 26973aa

Please sign in to comment.