Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: provider level tags #241

Closed
wants to merge 6 commits into from
Closed

enhancement: provider level tags #241

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4176d4
outline most used tags according to best practice
pvlbnkl Jun 8, 2023
626d3b8
add provider tags to all examples, terraform fmt
pvlbnkl Jun 9, 2023
c2883a5
remove equal sign
pvlbnkl Jul 14, 2023
8abeca4
fix everywhere else
pvlbnkl Jul 14, 2023
db5c028
deduplicate tags from eks module, use variables in tags
pvlbnkl Jul 21, 2023
0e01659
fix provider tags in other examples
pvlbnkl Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion examples/argocd-with-applications/providers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
provider "aws" {
region = var.region
default_tags {
Environment = "dev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Environment" and "Project" values could be retrieved from variables.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not fixed

Owner = "infra-team"
Project = "swiss-army-kube"
CostCenter = "infrastructure"
}
}

provider "kubernetes" {
Expand All @@ -14,4 +20,4 @@ provider "helm" {
cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority.0.data)
token = data.aws_eks_cluster_auth.cluster.token
}
}
}
4 changes: 2 additions & 2 deletions examples/argocd/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ module "eks" {
additional_userdata = "sudo yum install -y https://s3.amazonaws.com/ec2-downloads-windows/SSMAgent/latest/linux_amd64/amazon-ssm-agent.rpm && sudo systemctl enable amazon-ssm-agent && sudo systemctl start amazon-ssm-agent"
bootstrap_extra_args = local.default_bootstrap_extra_args
metadata_options = {
http_endpoint = "enabled"
http_tokens = "optional"
http_endpoint = "enabled"
http_tokens = "optional"
}
}

Expand Down
8 changes: 8 additions & 0 deletions examples/argocd/providers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
provider "aws" {
region = var.region
default_tags {
tags = {
Environment = "dev"
Owner = "infra-team"
Project = "swiss-army-kube"
CostCenter = "infrastructure"
}
}
}

provider "kubernetes" {
Expand Down
6 changes: 6 additions & 0 deletions examples/common/providers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
provider "aws" {
region = var.region
default_tags {
Environment = "dev"
Owner = "infra-team"
Project = "swiss-army-kube"
CostCenter = "infrastructure"
}
}

provider "kubernetes" {
Expand Down
8 changes: 7 additions & 1 deletion examples/docker-reverse-proxy/providers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
provider "aws" {
region = var.region
default_tags {
Environment = "dev"
Owner = "infra-team"
Project = "swiss-army-kube"
CostCenter = "infrastructure"
}
}

provider "kubernetes" {
Expand All @@ -14,4 +20,4 @@ provider "helm" {
cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority.0.data)
token = data.aws_eks_cluster_auth.cluster.token
}
}
}
Loading