-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: provider level tags #241
Conversation
I'll test it out. |
I've checked terraform code on branch.
|
@@ -1,5 +1,11 @@ | |||
provider "aws" { | |||
region = var.region | |||
default_tags = { | |||
Environment = "dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Environment" and "Project" values could be retrieved from variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not fixed
examples/argocd/providers.tf
Outdated
@@ -1,5 +1,11 @@ | |||
provider "aws" { | |||
region = var.region | |||
default_tags = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is incorrect declaration of default_tags for my terraform version. Does it work for your terraform version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, the main problem is fixed. One small change is required - some tags could be retrieved from terraform vars.
Add provider level tags to examples according to whitepaper here: https://docs.aws.amazon.com/whitepapers/latest/tagging-best-practices/tagging-best-practices.html
Also ran terraform fmt
Issue: #232