🐛 Fix FS cache for image refs with tags #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Edit: Ready for review Leaving in a draft for now because ideally we want to fail the test if we do not hit cache. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
- Coverage 33.95% 33.66% -0.29%
==========================================
Files 16 16
Lines 698 695 -3
==========================================
- Hits 237 234 -3
- Misses 435 436 +1
+ Partials 26 25 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
force-pushed
the
fix_fs_cache
branch
from
c36e717
to
df2b2f0
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
perdasilva
reviewed
Sep 12, 2024
| @@ -344,6 +347,16 @@ func TestImageRegistry(t *testing.T) { | |||
| BaseCachePath: testCache, | |||
| } | |||
|
|
|||
| // Create a logger with a simple function-based LogSink that writes to the buffer | |||
| var buf bytes.Buffer | |||
perdasilva
reviewed
Sep 12, 2024
| @@ -263,6 +263,8 @@ func (r *ClusterCatalogReconciler) needsUnpacking(catalog *v1alpha1.ClusterCatal | |||
| return false | |||
| } | |||
| // if the spec.Source.Image.Ref was changed, unpack the new ref | |||
| // NOTE: we must compare image reference WITHOUT sha hash here | |||
perdasilva
approved these changes
Sep 12, 2024
Merged
via the queue into
operator-framework:main
with commit Sep 12, 2024
dfe121e
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392