🐛 Avoid a network call for digest based images #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
+ Coverage 34.41% 35.29% +0.87%
==========================================
Files 17 17
Lines 738 731 -7
==========================================
+ Hits 254 258 +4
+ Misses 452 443 -9
+ Partials 32 30 -2 ☔ View full report in Codecov by Sentry. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
perdasilva
approved these changes
Sep 12, 2024
No worries. I missed it too :) |
tmshort
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing a bug in #394 I removed optimisation for digest based image. This PR changes the unpacker so that we do not make a network call for these images: only for tag-based images.