Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Convert slices to arrays instead of copy where possible #2885

Merged
merged 5 commits into from
Jul 9, 2024
Merged

*: Convert slices to arrays instead of copy where possible #2885

merged 5 commits into from
Jul 9, 2024

Commits on Jul 9, 2024

  1. adm/morph: Simplify filtering requested containers 

    Maps are much easier to implement/understand than `sort.Search`.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
    @cthulhu-rider
    cthulhu-rider committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    b1a8b3a View commit details
    Browse the repository at this point in the history

  2. adm/morph: Improve dump-containers command behavior 

    It makes no sense to preliminary request container list from the
contract: the list is specified via command flag. Verification of the
container IDs is also better to be done before any network access.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
    @cthulhu-rider
    cthulhu-rider committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    82983f4 View commit details
    Browse the repository at this point in the history

  3. *: Convert slices to arrays instead of copy where possible 

    Became possible with Go 1.20.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
    @cthulhu-rider
    cthulhu-rider committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3656208 View commit details
    Browse the repository at this point in the history

  4. adm/morph: Do not do no-op slice-to-slice cast 

    Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
    @cthulhu-rider
    cthulhu-rider committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    9e85517 View commit details
    Browse the repository at this point in the history

  5. reputation: Clone peer ID bytes instead of copying them into temp array 

    Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
    @cthulhu-rider
    cthulhu-rider committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    35ca2f1 View commit details
    Browse the repository at this point in the history