*: Convert slices to arrays instead of copy where possible
#2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2885 +/- ##
=======================================
Coverage 23.74% 23.74%
=======================================
Files 774 774
Lines 44801 44783 -18
=======================================
- Hits 10636 10634 -2
+ Misses 33311 33294 -17
- Partials 854 855 +1 ☔ View full report in Codecov by Sentry. |
carpawell
reviewed
Jul 8, 2024
Maps are much easier to implement/understand than `sort.Search`. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
It makes no sense to preliminary request container list from the contract: the list is specified via command flag. Verification of the container IDs is also better to be done before any network access. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Became possible with Go 1.20. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
carpawell
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.