Pass the right symbols directory to upload_android_symbols.sh (backport #6384) #6385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The command had a stray double quote after `crashreporter-symbols`, and wasn't pointing at $MOZ_FETCHES_DIR, so AFAICT it was not actually uploading anything. (cherry picked from commit 37a76bb)
rvandermeulen
approved these changes
Sep 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v131 #6385 +/- ##
=============================================
Coverage 22.64% 22.65%
=============================================
Files 327 327
Lines 29846 29837 -9
=============================================
Hits 6759 6759
+ Misses 23087 23078 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command had a stray double quote after
crashreporter-symbols, and wasn't pointing at $MOZ_FETCHES_DIR, so AFAICT it was not actually uploading anything.This is an automatic backport of pull request #6384 done by Mergify.