Pass the right symbols directory to upload_android_symbols.sh #6384
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command had a stray double quote after `crashreporter-symbols`, and wasn't pointing at $MOZ_FETCHES_DIR, so AFAICT it was not actually uploading anything.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6384 +/- ##
=======================================
Coverage 52.72% 52.72%
=======================================
Files 125 125
Lines 12820 12820
=======================================
Hits 6759 6759
Misses 6061 6061 ☔ View full report in Codecov by Sentry. |
bendk
approved these changes
Sep 20, 2024
|
@mergify backport release-v131 |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command had a stray double quote after
crashreporter-symbols, and wasn't pointing at $MOZ_FETCHES_DIR, so AFAICT it was not actually uploading anything.