Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag var shadowing, same scope #2272

Merged
merged 3 commits into from
Aug 15, 2024
Merged

feat: tag var shadowing, same scope #2272

merged 3 commits into from
Aug 15, 2024

Conversation

LuLaValva
Copy link
Member

Description

This is now allowed:

<let/x = 0/>
<div>
  <div>
    <let/x = 1/>
    ${x} // 1
  </div>
  ${x} // 0
</div>

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Aug 15, 2024

⚠️ No Changeset found

Latest commit: c994d88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 87.27273% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (3a820ad) to head (c994d88).
Report is 1 commits behind head on main.

Files Patch % Lines
packages/translator-tags/src/util/references.ts 82.35% 6 Missing ⚠️
packages/translator-tags/src/core/let.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2272      +/-   ##
==========================================
- Coverage   88.05%   88.05%   -0.01%     
==========================================
  Files         338      338              
  Lines       34963    35002      +39     
  Branches     2044     2054      +10     
==========================================
+ Hits        30788    30822      +34     
- Misses       4162     4167       +5     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuLaValva LuLaValva merged commit 441bdcb into main Aug 15, 2024
7 checks passed
@LuLaValva LuLaValva deleted the tag-var-shadowing branch August 15, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant