Skip to content

Commit

Permalink
feat: tag var shadowing, same scope (#2272)
Browse files Browse the repository at this point in the history
  • Loading branch information
LuLaValva committed Aug 15, 2024
1 parent 3a820ad commit 441bdcb
Show file tree
Hide file tree
Showing 21 changed files with 1,171 additions and 18 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"build:sizes": "node -r ~ts scripts/sizes",
"change": "changeset add",
"format": "eslint --format unix --fix .; prettier . --write --with-node-modules --log-level=warn",
"inspect:compiled": "node -r ~ts scripts/inspect-compiled-output.ts",
"lint": "eslint --format unix . && prettier . --check --with-node-modules --log-level=warn",
"prepare": "husky",
"report": "open ./coverage/lcov-report/index.html",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
at packages/translator-tags/src/__tests__/fixtures/let-tag-controllable-compile-error/template.marko:2:22
1 | <let/x=1/>
> 2 | <let/y=x valueChange=5 />
| ^ The 'let' tag 'valueChange' attribute must be a function.
| ^ The `let` tag `valueChange` attribute must be a function.
3 | <button onClick() { y++; }>
4 | ${x}|${y}
5 | </button>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
at packages/translator-tags/src/__tests__/fixtures/let-tag-controllable-compile-error/template.marko:2:22
1 | <let/x=1/>
> 2 | <let/y=x valueChange=5 />
| ^ The 'let' tag 'valueChange' attribute must be a function.
| ^ The `let` tag `valueChange` attribute must be a function.
3 | <button onClick() { y++; }>
4 | ${x}|${y}
5 | </button>
Original file line number Diff line number Diff line change
@@ -0,0 +1,158 @@
# Render {}
```html
<div>
<button>
0
</button>
<div>
<button>
0
</button>
<div>
<button>
0
</button>
</div>
</div>
</div>
<div>
<button>
0
</button>
</div>
```


# Render
container.querySelectorAll("button")[buttonNum++].click()

```html
<div>
<button>
1
</button>
<div>
<button>
0
</button>
<div>
<button>
0
</button>
</div>
</div>
</div>
<div>
<button>
0
</button>
</div>
```


# Render
container.querySelectorAll("button")[buttonNum++].click()

```html
<div>
<button>
1
</button>
<div>
<button>
1
</button>
<div>
<button>
0
</button>
</div>
</div>
</div>
<div>
<button>
0
</button>
</div>
```


# Render
container.querySelectorAll("button")[buttonNum++].click()

```html
<div>
<button>
1
</button>
<div>
<button>
1
</button>
<div>
<button>
1
</button>
</div>
</div>
</div>
<div>
<button>
0
</button>
</div>
```


# Render
container.querySelectorAll("button")[buttonNum++].click()

```html
<div>
<button>
1
</button>
<div>
<button>
1
</button>
<div>
<button>
1
</button>
</div>
</div>
</div>
<div>
<button>
1
</button>
</div>
```


# Render
buttonNum = 0

```html
<div>
<button>
1
</button>
<div>
<button>
1
</button>
<div>
<button>
1
</button>
</div>
</div>
</div>
<div>
<button>
1
</button>
</div>
```
Original file line number Diff line number Diff line change
@@ -0,0 +1,188 @@
# Render {}
```html
<div>
<button>
0
</button>
<div>
<button>
0
</button>
<div>
<button>
0
</button>
</div>
</div>
</div>
<div>
<button>
0
</button>
</div>
```

# Mutations
```
inserted div0, div1
```


# Render
container.querySelectorAll("button")[buttonNum++].click()

```html
<div>
<button>
1
</button>
<div>
<button>
0
</button>
<div>
<button>
0
</button>
</div>
</div>
</div>
<div>
<button>
0
</button>
</div>
```

# Mutations
```
div0/button0/#text0: "0" => "1"
```


# Render
container.querySelectorAll("button")[buttonNum++].click()

```html
<div>
<button>
1
</button>
<div>
<button>
1
</button>
<div>
<button>
0
</button>
</div>
</div>
</div>
<div>
<button>
0
</button>
</div>
```

# Mutations
```
div0/div1/button0/#text0: "0" => "1"
```


# Render
container.querySelectorAll("button")[buttonNum++].click()

```html
<div>
<button>
1
</button>
<div>
<button>
1
</button>
<div>
<button>
1
</button>
</div>
</div>
</div>
<div>
<button>
0
</button>
</div>
```

# Mutations
```
div0/div1/div1/button0/#text0: "0" => "1"
```


# Render
container.querySelectorAll("button")[buttonNum++].click()

```html
<div>
<button>
1
</button>
<div>
<button>
1
</button>
<div>
<button>
1
</button>
</div>
</div>
</div>
<div>
<button>
1
</button>
</div>
```

# Mutations
```
div1/button0/#text0: "0" => "1"
```


# Render
buttonNum = 0

```html
<div>
<button>
1
</button>
<div>
<button>
1
</button>
<div>
<button>
1
</button>
</div>
</div>
</div>
<div>
<button>
1
</button>
</div>
```

# Mutations
```
```
Loading

0 comments on commit 441bdcb

Please sign in to comment.