Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILCI CACCIA Method Requests #12

Merged
merged 6 commits into from
Nov 8, 2023
Merged

ILCI CACCIA Method Requests #12

merged 6 commits into from
Nov 8, 2023

Conversation

btmonier
Copy link
Member

@btmonier btmonier commented Nov 8, 2023

This PR adds 3 primary features/fixes:

  • Fixed typo in plotPCA() error message
  • Add new function filterGenotypeTableBySiteName():
    • Filters genotype tables using literal marker names/IDs
  • Add new function mergeGenotypeTables():
    • Merges multiple genotype tables by site values

@btmonier btmonier requested a review from zrm22 November 8, 2023 14:07
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (42ceeb1) 95.69% compared to head (9d01897) 95.51%.

❗ Current head 9d01897 differs from pull request most recent head ceffee7. Consider uploading reports for the commit ceffee7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   95.69%   95.51%   -0.18%     
==========================================
  Files          31       31              
  Lines        1883     1919      +36     
==========================================
+ Hits         1802     1833      +31     
- Misses         81       86       +5     
Files Coverage Δ
R/join_methods.R 100.00% <100.00%> (ø)
R/filter_functions.R 91.09% <91.09%> (-0.25%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@btmonier btmonier merged commit 80e7c0e into master Nov 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants