Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default sorting direction #543

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Fix default sorting direction #543

merged 1 commit into from
Jul 11, 2023

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jul 11, 2023 •
edited
Loading

Default sorting order should be ascending

Fixes: #542

Screenshot:
Before:
before

After:
after

@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Jul 11, 2023
@yaacov yaacov added this to the 2.5.0 milestone Jul 11, 2023
@yaacov
Copy link
Member Author

yaacov commented Jul 11, 2023

cc: @orenc1

@yaacov yaacov changed the title Ascending is reverce order, use -compaerator on Asc Ascending is reverse order, use -comperator on Asc Jul 11, 2023
@yaacov yaacov changed the title Ascending is reverse order, use -comperator on Asc Ascending is reverse order, use -comparator on Asc Jul 11, 2023
@yaacov yaacov changed the title Ascending is reverse order, use -comparator on Asc Fix default sorting direction Jul 11, 2023
@yaacov yaacov closed this Jul 11, 2023
@yaacov yaacov reopened this Jul 11, 2023
@yaacov
default sort is ascending
2d238c1 
Signed-off-by: yaacov <yzamir@redhat.com>
@yaacov yaacov merged commit 35d5acf into kubev2v:main Jul 11, 2023
3 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
14.3% 14.3% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjd78 sjd78 Awaiting requested review from sjd78

@sgratch sgratch Awaiting requested review from sgratch

@rszwajko rszwajko Awaiting requested review from rszwajko

Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Default sort order is reversed
1 participant
@yaacov