default sort is ascending

Signed-off-by: yaacov <yzamir@redhat.com>
kubev2v · Jul 11, 2023 · 2d238c1 · 2d238c1
1 parent 532f0eb
commit 2d238c1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/common/src/components/TableView/__tests__/useSort.test.tsx b/packages/common/src/components/TableView/__tests__/useSort.test.tsx
@@ -17,7 +17,7 @@ describe('useSort hook', () => {
     expect(activeSort).toMatchObject({
       resourceFieldId: NAME,
       label: NameColumn.label,
-      isAsc: false,
+      isAsc: true,
     });
   });
 
@@ -31,7 +31,7 @@ describe('useSort hook', () => {
     expect(activeSort).toMatchObject({
       resourceFieldId: 'Foo',
       label: undefined,
-      isAsc: false,
+      isAsc: true,
     });
   });
 
@@ -45,7 +45,7 @@ describe('useSort hook', () => {
     expect(activeSort).toMatchObject({
       resourceFieldId: undefined,
       label: undefined,
-      isAsc: false,
+      isAsc: true,
     });
 
     expect(setActiveSort).toBeDefined();

diff --git a/packages/common/src/components/TableView/sort.ts b/packages/common/src/components/TableView/sort.ts
@@ -66,7 +66,8 @@ export const useSort = (
   );
 
   const [activeSort, setActiveSort] = useState<SortType>({
-    isAsc: false,
+    // when no other order is define, default to ascending order
+    isAsc: true,
     resourceFieldId: firstField?.resourceFieldId,
     label: firstField?.label,
   });