🐞 Fix Negative number for plan/migration status VMs count #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On both plan and migration status fields, the number of displayed migrated VMs within the status' progress bar label is sometimes negative, i.e. the value of X within "X out of Y VMs migrated" is sometimes negative. This is reproduced when at least one VM failed to migrated. The reason is that failed VMs is often marked with an error but their completed value is still set to false since VM's migration was not finished yet. So the calculation of migrated = completed - error < 0. Signed-off-by: Sharon Gratch <sgratch@redhat.com>
|
sgratch
changed the title
|
I'm ok with this fix as a temporary "hot fix" for the negative values, until we have time to fix #1284 - note that 1284 should address the correctness of all parameters including the success but not just it, the fix should also address the correctness during the time the user request a start of a migration and the time the values are updated in the plan CR ( see: #1283 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On both plan and migration status fields, the number of displayed migrated VMs within the status' progress bar label is sometimes negative, i.e. the value of
Xwithin"X of Y VMs migrated"is sometimes negative.This is reproduced when at least one VM failed to migrate.
The reason is that failed VMs are often marked with an error but they are not marked as completed yet, so the calculation of migrated = completed - error < 0.
Before:
After: