Merge pull request #1319 from sgratch/avoid-negative-number-for-succe…

…ssed-migrated-vms-count 🐞 Fix Negative number for plan/migration status VMs count
kubev2v · Sep 8, 2024 · 91ce362 · 91ce362
2 parents 7e85021 + 792730b
commit 91ce362
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getMigrationVmsCounts.ts b/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getMigrationVmsCounts.ts
@@ -18,13 +18,14 @@ export const getMigrationVmsCounts = (vms: V1beta1PlanStatusMigrationVms[]): Mig
   );
   const vmsCompleted = vms.filter((vm) => vm?.completed);
   const vmsError = vms.filter((vm) => vm?.error);
+  const success = vmsCompleted.length - vmsError.length - vmsCanceled.length;
 
   return {
     completed: vmsCompleted.length,
     total: vms.length,
     canceled: vmsCanceled.length,
     error: vmsError.length,
-    success: vmsCompleted.length - vmsError.length - vmsCanceled.length,
+    success: success >= 0 ? success : 0,
   };
 };