generated from konveyor/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ fix expected issues for tackle testapp #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aufi
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pranavgaikwad
force-pushed
the
main
branch
6 times, most recently
from
November 13, 2023 13:29
588022d
to
5e37125
Compare
aufi
reviewed
Nov 13, 2023
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
pranavgaikwad
force-pushed
the
main
branch
2 times, most recently
from
November 14, 2023 19:18
ebbe4b8
to
c9a2b73
Compare
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
TIER-0 on this test is failling because the addon hasn't been rebuilt with latest analyzer changes required (mentioned in description) |
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
mguetta1
pushed a commit
to mguetta1/go-konveyor-tests
that referenced
this pull request
Dec 5, 2023
* ✨ fix expected issues for tackle testapp Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 fix identity uniqueness Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 update m2 location in file URI Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 fix dep output Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 update file uri Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 add back withDeps to Tier 0 Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 fix test Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 add token Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 uncomment t.Errorf Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 👻 revert tackle testapp public test Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 👻 move non deps tackle testapp test to tier2 Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 👻 update dependencies Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 👻 add back log lines Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> --------- Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
aufi
pushed a commit
that referenced
this pull request
Dec 13, 2023
* ✨ fix expected issues for tackle testapp Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 fix identity uniqueness Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 update m2 location in file URI Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 fix dep output Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 update file uri Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 add back withDeps to Tier 0 Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 fix test Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 add token Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 uncomment t.Errorf Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 👻 revert tackle testapp public test Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 👻 move non deps tackle testapp test to tier2 Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 👻 update dependencies Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 👻 add back log lines Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> --------- Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
mguetta1
pushed a commit
to mguetta1/go-konveyor-tests
that referenced
this pull request
Jan 31, 2024
* ✨ fix expected issues for tackle testapp Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 fix identity uniqueness Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 update m2 location in file URI Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 fix dep output Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 update file uri Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 add back withDeps to Tier 0 Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 fix test Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 add token Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 🐛 uncomment t.Errorf Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 👻 revert tackle testapp public test Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 👻 move non deps tackle testapp test to tier2 Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 👻 update dependencies Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> * 👻 add back log lines Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> --------- Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on konveyor/analyzer-lsp#426, #52 #53