Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ fix expected issues for tackle testapp #55

Merged
merged 13 commits into from
Nov 16, 2023

Conversation

pranavgaikwad
Copy link
Contributor

@pranavgaikwad pranavgaikwad commented Nov 9, 2023

@pranavgaikwad pranavgaikwad marked this pull request as draft November 9, 2023 22:19
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

analysis/analysis_test.go Outdated Show resolved Hide resolved
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad pranavgaikwad marked this pull request as ready for review November 15, 2023 18:52
@pranavgaikwad
Copy link
Contributor Author

TIER-0 on this test is failling because the addon hasn't been rebuilt with latest analyzer changes required (mentioned in description)

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad pranavgaikwad merged commit c24952c into konveyor:main Nov 16, 2023
3 of 4 checks passed
mguetta1 pushed a commit to mguetta1/go-konveyor-tests that referenced this pull request Dec 5, 2023
* ✨ fix expected issues for tackle testapp

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 fix identity uniqueness

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 update m2 location in file URI

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 fix dep output

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 update file uri

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 add back withDeps to Tier 0

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 fix test

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 add token

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 uncomment t.Errorf

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 👻 revert tackle testapp public test

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 👻 move non deps tackle testapp test to tier2

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 👻 update dependencies

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 👻 add back log lines

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

---------

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
aufi pushed a commit that referenced this pull request Dec 13, 2023
* ✨ fix expected issues for tackle testapp

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 fix identity uniqueness

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 update m2 location in file URI

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 fix dep output

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 update file uri

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 add back withDeps to Tier 0

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 fix test

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 add token

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 uncomment t.Errorf

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 👻 revert tackle testapp public test

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 👻 move non deps tackle testapp test to tier2

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 👻 update dependencies

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 👻 add back log lines

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

---------

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
mguetta1 pushed a commit to mguetta1/go-konveyor-tests that referenced this pull request Jan 31, 2024
* ✨ fix expected issues for tackle testapp

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 fix identity uniqueness

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 update m2 location in file URI

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 fix dep output

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 update file uri

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 add back withDeps to Tier 0

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 fix test

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 add token

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 🐛 uncomment t.Errorf

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 👻 revert tackle testapp public test

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 👻 move non deps tackle testapp test to tier2

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 👻 update dependencies

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

* 👻 add back log lines

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>

---------

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants