Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send separate nightly email for comments #1151

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

andrewbiang888
Copy link
Collaborator

@andrewbiang888 andrewbiang888 commented Feb 4, 2021

This PR pulls out comment activity into a separate email to make it easier for city/campaigns to parse. This PR follows the existing pattern of having the city be cc'd on campaign emails. Should be send two emails instead?

Ref: #1131

@andrewbiang888 andrewbiang888 marked this pull request as ready for review February 4, 2021 16:08
Copy link
Contributor

@jaronheard jaronheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that following the same pattern as the activity emails makes sense for now.

@jaronheard
Copy link
Contributor

As a note, a couple of potential items to follow up on:

  • link comment to associated transaction by id (this is a little tricky because the activity log doesn't have a transaction id, but should be somewhat low-hanging fruit)
  • maybe someday we should make previewing emails in development easier, but this is not low-hanging fruit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants