Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates tests to CRS 4.5, albedo #1122

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Aug 3, 2024

Requires further investigation on a few failing tests.
Notably:

  • Relies on albedo instead of emulating it (or go-httpbin)
  • Starts transition from a generic list of ignored tests to a more detailed list of overrides, with the expected behaviours of these tests in the context of Coraza

@M4tteoP M4tteoP force-pushed the crs4_5_albedo branch 3 times, most recently from 6929283 to bc44a14 Compare August 9, 2024 08:54
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.91%. Comparing base (4ff1f76) to head (c6af3d4).
Report is 81 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
+ Coverage   82.72%   83.91%   +1.19%     
==========================================
  Files         162      166       +4     
  Lines        9080     7891    -1189     
==========================================
- Hits         7511     6622     -889     
+ Misses       1319     1019     -300     
  Partials      250      250              
Flag Coverage Δ
default 83.91% <ø> (+6.08%) ⬆️
examples 83.91% <ø> (+57.48%) ⬆️
ftw 83.91% <ø> (+36.55%) ⬆️
ftw-multiphase 83.91% <ø> (+34.37%) ⬆️
tinygo 83.91% <ø> (+8.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@M4tteoP
Copy link
Member Author

M4tteoP commented Sep 24, 2024

:shipit:

😅. There is still some work to do, but this is still progress that should be okay to be merged. From this PR, I also started reducing the number of tests ignored via the generic ignore list in .ftw.yml in favor of the expected outcomes of these tests, provided by .ftw-overrides.yml. I left a comment about it in .ftw.yml.

@M4tteoP M4tteoP marked this pull request as ready for review September 24, 2024 22:14
@M4tteoP M4tteoP requested a review from a team as a code owner September 24, 2024 22:14
@M4tteoP M4tteoP changed the title [wip] CRS 4.5, albedo updates tests to CRS 4.5, albedo Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants