Skip to content

Commit

Permalink
moves comment about .ftw-overrides.yml to .ftw.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
M4tteoP committed Sep 24, 2024
1 parent 092d126 commit a226787
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 2 additions & 0 deletions testing/coreruleset/.ftw.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# Tests would not just be ignored via .ftw.yml, but new expectations for each test should be set.
# This file should be gradually deprecated in favor of .ftw-overrides.yml, avoid as much as possible to add new entries here.
---
testoverride:
ignore:
Expand Down
5 changes: 1 addition & 4 deletions testing/coreruleset/coreruleset_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,7 @@ SecRule REQUEST_HEADERS:X-CRS-Test "@rx ^.*$" \
cfg.WithLogfile(errorPath)
cfg.TestOverride.Overrides.DestAddr = &host
cfg.TestOverride.Overrides.Port = &port
// TODO(M4tteoP)
// cfg.LoadPlatformOverrides(): .ftw.yml should become a platform override file
// Tests would not just be ignored, but new expectations would be set for the specific platform
// E.g. see https://github.com/coreruleset/coreruleset/blob/main/tests/regression/nginx-overrides.yaml

cfg.LoadPlatformOverrides(".ftw-overrides.yml")
res, err := runner.Run(cfg, tests, runner.RunnerConfig{
ShowTime: false,
Expand Down

0 comments on commit a226787

Please sign in to comment.