RFC-0030 - Add support to Diego for file based service bindings #100
+523
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitardimitrov13
force-pushed
the
CFAR-929_VCAP_SERVICES
branch
from
2c59134
to
2f5337e
Compare
Remove ioutil.ReadFile in favor of os.ReadFile. Remove MkdirAll in favor of Mkdir.
dimitardimitrov13
force-pushed
the
CFAR-929_VCAP_SERVICES
branch
from
2f5337e
to
fa28a86
Compare
| return nil | ||
| } | ||
|
|
||
| func (h *ServiceBindingRootHandler) RemoveDir(logger lager.Logger, container executor.Container) error { |
There was a problem hiding this comment.
I do not see this function covered with tests, or am i wrong?
There was a problem hiding this comment.
Hello here it is the test for RemoveDir
https://github.com/cloudfoundry/executor/pull/100/files#diff-5e39d32f309883624104dc2056437db4a3d782ea689020c000a3848675ca80d8R81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is continuation for the RFC-0030
Backward Compatibility
Breaking Change? No
This feature is the first PoC for RFC-0030.
Since the CAPI implementation for RFC-0030 is not done yet, the PR doesn't need to be applied immediately.