Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC0030] Add Support for File based Service Binding Information #901

Open
4 tasks
beyhan opened this issue Jun 18, 2024 · 8 comments
Open
4 tasks

[RFC0030] Add Support for File based Service Binding Information #901

beyhan opened this issue Jun 18, 2024 · 8 comments
Labels
rfc CFF community RFC

Comments

@beyhan
Copy link
Member

beyhan commented Jun 18, 2024

This is a tracking issue for the implementation of https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0030-add-support-for-file-based-service-binding.md

@beyhan beyhan added the rfc CFF community RFC label Jun 18, 2024
@dimitardimitrov13
Copy link

Hello there, here are the 4 PRs within diego-release, bbs, rep, and executor. They are needed for RFC-0030.

  1. Diego Release: RFC-0030 - Add support to Diego for file based service bindings diego-release#942
  2. BBS: RFC-0030 Add support to Diego for file based service bindings  bbs#100
  3. REP: RFC-0030 - Add support to Diego for file based service bindings rep#56
  4. Executor: RFC-0030 - Add support to Diego for file based service bindings  executor#100

@beyhan
Copy link
Member Author

beyhan commented Jul 25, 2024

@dimitardimitrov13 thanks for the update! I updated the tasks list.

@dimitardimitrov13
Copy link

@beyhan, thank you.

@ameowlia
Copy link
Member

ameowlia commented Aug 6, 2024

🎉 Hi @dimitardimitrov13 , Excellent work so far!

Please ping me on slack (too easy to miss github notifications with 100+ repos 🫠 ) when the CAPI PRs are done and we can test this end-to-end. At that point I will assign a Diego reviewer.

@dimitardimitrov13
Copy link

Hello Amelia,

Thanks for your message. Unfortunately, we do not have a straightforward way to test this end-to-end. During the implementation stage, I used a custom build of cfdot and a mocked code inside the BBS to simulate this. The code was cleaned up from the BBS before the PR. It seems we will need to wait for the CAPI team.

Best regards,
Dimitar

@PlamenDoychev
Copy link
Contributor

Hi @ameowlia,

Just in case you haven't seen the input from @dimitardimitrov13 above.
Should we wait for CAPI then?

@beyhan
Copy link
Member Author

beyhan commented Sep 3, 2024

Should we wait for CAPI then?

This is what I read in the comment above #901 (comment)

@ameowlia
Copy link
Member

ameowlia commented Sep 5, 2024

Yes, I want to wait to review and merge until we can test it end-to-end. That way we can make sure everything works all the way through and we don't have to worry about breaking changes if part of it is released, but then it ends up things need to change to work with CAPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc CFF community RFC
Projects
Status: In Progress
Development

No branches or pull requests

4 participants