Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and bugfixes for command-line interface #248

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

dr-orlovsky
Copy link
Member

@dr-orlovsky dr-orlovsky commented Sep 7, 2024

This also includes #254 and closes #204

@dr-orlovsky dr-orlovsky added the bug Something isn't working label Sep 7, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.1 milestone Sep 7, 2024
@dr-orlovsky dr-orlovsky self-assigned this Sep 7, 2024
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 283 lines in your changes missing coverage. Please review.

Project coverage is 2.8%. Comparing base (e3bb8e3) to head (a3b2e43).

Files with missing lines Patch % Lines
cli/src/command.rs 0.0% 214 Missing ⚠️
src/filters.rs 0.0% 18 Missing ⚠️
src/wallet.rs 0.0% 16 Missing ⚠️
src/pay.rs 0.0% 14 Missing ⚠️
cli/src/args.rs 0.0% 11 Missing ⚠️
src/lib.rs 0.0% 7 Missing ⚠️
cli/src/main.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #248     +/-   ##
=======================================
- Coverage     3.0%   2.8%   -0.3%     
=======================================
  Files          14     15      +1     
  Lines        1753   1915    +162     
=======================================
  Hits           53     53             
- Misses       1700   1862    +162     
Flag Coverage Δ
rust 2.8% <0.0%> (-0.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky changed the title Improvements to command-line interface Improvements and bugfixes for command-line interface Sep 21, 2024
@dr-orlovsky dr-orlovsky modified the milestones: v0.11.1, v0.11.0 Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

cli: enable invoice for UDA
1 participant