Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: enable invoice for UDA #204

Open
zoedberg opened this issue May 29, 2024 · 6 comments · May be fixed by #248
Open

cli: enable invoice for UDA #204

zoedberg opened this issue May 29, 2024 · 6 comments · May be fixed by #248
Assignees
Labels
Milestone

Comments

@zoedberg
Copy link
Contributor

Currently via CLI it's not possible to create an invoice to receive a UDA.

@crisdut could you please take care of this?

@crisdut
Copy link
Member

crisdut commented May 30, 2024

@crisdut could you please take care of this?

Yes!

@zoedberg
Copy link
Contributor Author

zoedberg commented Jul 4, 2024

@crisdut any news on this?

@crisdut
Copy link
Member

crisdut commented Jul 4, 2024

@crisdut any news on this?

I'm having a hard time finding the time to do this, but give me a few days and I'll do it.

@dr-orlovsky
Copy link
Member

@zoedberg what are the specific requirements to create an UDA invoice via the cli?

@zoedberg
Copy link
Contributor Author

@zoedberg what are the specific requirements to create an UDA invoice via the cli?

If we detect that the user is creating an invoice to receive an UDA contract then we should call RgbInvoiceBuilder::set_allocation_raw instead of RgbInvoiceBuilder::set_amount_raw. And Command::Invoice should ignore value or make it optional

@dr-orlovsky
Copy link
Member

The last three commits in #248 are now do the NFT (and all other forms) of invoicing, closing this issue.

I first tried to do it as a dedicated PR, but it was not possible since I needed a lot of stuff I did in the develop branch already, so I just added those things on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In review
Development

Successfully merging a pull request may close this issue.

3 participants