Bug: Explicit require net/http #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure why CI isn't running, but I'm going to go ahead and merge this. thanks! |
|
@thatbudakguy it looks the CI only runs on commits & not PRs! GeoCombine/.github/workflows/ruby.yml Line 3 in 55add25 |
|
oh, good catch! I should fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks!
We're working on a small CLI gem for our in-house GBL that uses GeoCombine. We hit a small bug with
GeoCombine::Harvester. calling.repositoriesthrows:NameError: uninitialized constant GeoCombine::Harvester::Netfrom this line
GeoCombine/lib/geo_combine/harvester.rb
Line 104 in 2d59072
Adding an explicit
require 'net/http'toharvester.rbsolved it; this PR includes that & a small second commit to make rubocop test pass (edit: looks redundant with #157?)Spec tests passed locally on ruby-3.2.2.