Commits on Mar 18, 2024

1. Error cleanup (Intel Fortran) …

   This patch clears out many errors detected by Intel Fortran.
   
   Most are false positives from stub functions which would normally be
   replaced in production and report unset output.  These variables are now
   assigned dummy values in order to pacify the compiler.
   
   The `stat` function in POSIX was incorrectly passing its `buf` object to
   the C `stat` function as `intent(in)`, causing the compiler to believe
   that the contents were unset.  Oddly, this was already working
   correctly, and perhaps warrants further investigation, but it has now
   been correctly set to `intent(inout)`.
   
   The `ppoly_*` variables in `check_reconstruction_1d` appear to have been
   incorrectly declared as `out`, when they are clearly used as `in` to
   validate the values.  This has been corrected.
   
   `register_diag_field` in the ice shelf diag manager was incorrectly
   declared and the function appeared to return nothing.  Perhaps this
   function was not used for anything.
   
   An IO statement in MOM_open_boundary had a syntax error; this has been
   fixed.
   
   `get_dataset` returns a `dataset_type`, so some compilers expect the
   stub function to also return a valid `dataset`.  Since the stub
   `dataset_type` contains no fields, any locally declared instance should
   be sufficient as a return value.

   

   marshallward committed Mar 18, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for dc24883
   • Browse repository at this point

   Copy the full SHA

   dc24883 View commit details

   Browse the repository at this point in the history