Error cleanup (Intel Fortran) #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch clears out many errors detected by Intel Fortran. Most are false positives from stub functions which would normally be replaced in production and report unset output. These variables are now assigned dummy values in order to pacify the compiler. The `stat` function in POSIX was incorrectly passing its `buf` object to the C `stat` function as `intent(in)`, causing the compiler to believe that the contents were unset. Oddly, this was already working correctly, and perhaps warrants further investigation, but it has now been correctly set to `intent(inout)`. The `ppoly_*` variables in `check_reconstruction_1d` appear to have been incorrectly declared as `out`, when they are clearly used as `in` to validate the values. This has been corrected. `register_diag_field` in the ice shelf diag manager was incorrectly declared and the function appeared to return nothing. Perhaps this function was not used for anything. An IO statement in MOM_open_boundary had a syntax error; this has been fixed. `get_dataset` returns a `dataset_type`, so some compilers expect the stub function to also return a valid `dataset`. Since the stub `dataset_type` contains no fields, any locally declared instance should be sufficient as a return value.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/emc #130 +/- ##
===========================================
- Coverage 37.45% 37.44% -0.02%
===========================================
Files 270 270
Lines 79765 79800 +35
Branches 14833 14833
===========================================
Hits 29878 29878
- Misses 44350 44385 +35
Partials 5537 5537 ☔ View full report in Codecov by Sentry. |
14 tasks
|
@jiandewang @DeniseWorthen are you able to provide a review for this sub-component PR? UFS-WM PR 2197 could be an option to test against soon. |
DeniseWorthen
approved these changes
Mar 22, 2024
|
thanks for @marshallward work. It eliminated those warning now. |
jiandewang
approved these changes
Mar 22, 2024
14 tasks
|
@jiandewang testing is complete on UFS-WM PR #2202. Please merge this MOM6 PR when you're able. |
|
just merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch clears out many errors detected by Intel Fortran.
Most are false positives from stub functions which would normally be replaced in production and report unset output. These variables are now assigned dummy values in order to pacify the compiler.
The
statfunction in POSIX was incorrectly passing itsbufobject to the Cstatfunction asintent(in), causing the compiler to believe that the contents were unset. Oddly, this was already working correctly, and perhaps warrants further investigation, but it has now been correctly set tointent(inout).The
ppoly_*variables incheck_reconstruction_1dappear to have been incorrectly declared asout, when they are clearly used asinto validate the values. This has been corrected.register_diag_fieldin the ice shelf diag manager was incorrectly declared and the function appeared to return nothing. Perhaps this function was not used for anything.An IO statement in MOM_open_boundary had a syntax error; this has been fixed.
get_datasetreturns adataset_type, so some compilers expect the stub function to also return a validdataset. Since the stubdataset_typecontains no fields, any locally declared instance should be sufficient as a return value.