Ensure instance-updated event is passed up from Instance Danger component #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pezmc
approved these changes
Jun 30, 2023
Merged
11 tasks
knolleary
added a commit
that referenced
this pull request
Jul 4, 2023
Ensure instance-updated event is passed up from Instance Danger component (backport #2371)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2364
Description
When updating an instance stack, the 'instance-updated' event wasn't being passed up from the Danger component. This mean the overview page didn't know to refresh the review - so the stack 'update' didn't disappear and there's no feedback anything is happening.
Checklist
flowforge.yml?flowforge/helmto update ConfigMap Templateflowforge/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel