Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating stack doesn't confirm anything is happening #2364

Closed
robmarcer opened this issue Jun 29, 2023 · 5 comments · Fixed by #2371
Closed

Updating stack doesn't confirm anything is happening #2364

robmarcer opened this issue Jun 29, 2023 · 5 comments · Fixed by #2371
Assignees
Labels
bug Something isn't working size:XS - 1 Sizing estimation point
Milestone

Comments

@robmarcer
Copy link
Contributor

robmarcer commented Jun 29, 2023

Current Behavior

When there is a new stack available, an update button is shown in the instance overview page.

If that is clicked it makes you to the instances settings page, if I then click the button to update stack I'm given no confirmation anything is happening.

This resulted in my trying a couple of times before I concluded that it was actually updating but no message had confirmed that.

Expected Behavior

I should be told the stack is updating so that I don't try again.

Steps To Reproduce

Go to instance overview for an instance on a legacy stack.

Click update

On the next page click update stack.

Environment

  • FlowForge version: 1.8 (FF Cloud)
  • Node.js version: NA
  • npm version: NA
  • Platform/OS: NA
  • Browser: NA

Have you provided an initial effort estimate for this issue?

I can not provide an initial effort estimate

@robmarcer robmarcer added the needs-triage Needs looking at to decide what to do label Jun 29, 2023
@MarianRaphael MarianRaphael added bug Something isn't working and removed needs-triage Needs looking at to decide what to do labels Jun 29, 2023
@knolleary knolleary self-assigned this Jun 29, 2023
@knolleary
Copy link
Member

Where did you see this? In production/staging/local?

There is an open issue with our 'loading' animations not showing properly in the current development version (local/staging) - #2354 - which could be a cause of the issue here. That said, you ought to get a toast notifation in the top right when the update is complete.

There is a bug to be fixed that after the update completes it takes you back to the overview page, but the 'update' button is still there... something isn't quite refreshing properly.

If you tell me this was on Production, then something else is going on...

@robmarcer
Copy link
Contributor Author

Hello, this was production.

Sorry I said 1.9 when it's actually 1.8, I'll update the issue.

@robmarcer
Copy link
Contributor Author

This shows the issue - https://d.pr/v/5VetVw

To be fair, it's possible I missed the confirmation pop up.

@knolleary
Copy link
Member

I just tried to recreate in production. I got a fleeting bit of feedback, before being redirected to the overview page. But the 'update' button remained and there was no feedback the app was restarting.

In fact, as I type, you've shared a video that shows the same - which is good news. I've identified the cause of why the overview page doesn't refresh and have raised a PR that fixes that bit - #2371

@Pezmc
Copy link
Contributor

Pezmc commented Jul 6, 2023

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XS - 1 Sizing estimation point
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants