Skip to content

Commit

Permalink
convert to gjs
Browse files Browse the repository at this point in the history
  • Loading branch information
amk221 committed Dec 19, 2023
1 parent 34e0c22 commit 1f4acec
Show file tree
Hide file tree
Showing 7 changed files with 50 additions and 37 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 3.5.4

- Convert to `.gjs`

## 3.5.3

- Run ember-cli-update
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import { inject } from '@ember/service';
import Component from '@glimmer/component';
import { modifier } from 'ember-modifier';
import { action } from '@ember/object';
import { fn } from '@ember/helper';
import Message from '@zestia/ember-messages/components/message';

export default class FlashMessageComponent extends Component {
@inject('flash-message') flashMessageService;
Expand All @@ -24,4 +26,21 @@ export default class FlashMessageComponent extends Component {
handleDismissMessage(message) {
this.flashMessageService.remove(message);
}

<template>
{{#if this.flashMessageService.queue.length}}
<div class="flash-messages">
{{#each this.flashMessageService.queue as |message|}}
<Message
class="flash-message"
@type={{message.type}}
@onDismiss={{fn this.handleDismissMessage message}}
{{this.scrollIntoView}}
>
{{message.text}}
</Message>
{{/each}}
</div>
{{/if}}
</template>
}
14 changes: 0 additions & 14 deletions addon/components/flash-messages/index.hbs

This file was deleted.

24 changes: 24 additions & 0 deletions addon/components/message/index.js → addon/components/message.gjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { tracked } from '@glimmer/tracking';
import { waitFor } from '@ember/test-waiters';
import { waitForAnimation } from '@zestia/animation-utils';
import { modifier } from 'ember-modifier';
import { on } from '@ember/modifier';
import { action } from '@ember/object';

export default class MessageComponent extends Component {
Expand Down Expand Up @@ -31,4 +32,27 @@ export default class MessageComponent extends Component {

this.args.onDismiss();
}

<template>
<div
role="alert"
class="message"
data-type={{@type}}
data-dismissed={{this.dismissed}}
...attributes
{{this.registerElement}}
>
<div class="message__body">
{{yield}}
</div>
{{#if this.isDismissible}}
<button
type="button"
class="message__dismiss"
aria-label="Dismiss"
{{on "click" this.dismiss}}
></button>
{{/if}}
</div>
</template>
}
20 changes: 0 additions & 20 deletions addon/components/message/index.hbs

This file was deleted.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"ember-auto-import": "^2.7.1",
"ember-cli-babel": "^8.2.0",
"ember-cli-htmlbars": "^6.3.0",
"ember-modifier": "^4.1.0"
"ember-modifier": "^4.1.0",
"ember-template-imports": "^4.0.0"
},
"description": "Message components for Ember apps & addons",
"devDependencies": {
Expand Down Expand Up @@ -35,7 +36,6 @@
"ember-resolver": "^11.0.1",
"ember-source": "~5.5.0",
"ember-source-channel-url": "^3.0.0",
"ember-template-imports": "^4.0.0",
"ember-template-lint": "^5.13.0",
"ember-try": "^3.0.0",
"eslint": "^8.56.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/flash-messages/component-test.gjs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module('flash-messages', function (hooks) {
await render(<template><FlashMessages /></template>);

assert.strictEqual(
getRootElement().innerHTML,
getRootElement().innerHTML.trim(),
'<!---->',
'does not render if there are no flash messages to display'
);
Expand Down

0 comments on commit 1f4acec

Please sign in to comment.