Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCS SignedURL発行ロジックの追加 #89

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

GCS SignedURL発行ロジックの追加 #89

wants to merge 5 commits into from

Conversation

Shion1305
Copy link
Member

  • ✨ (pkg/gcs)NewFolderRef
  • ✨ (pkg/gcs) add security options for IssueLink()
  • ♻️ (pkg/gcs) IssueLink -> IssueDownloadSignedURL
  • 📌 go mod tidy
  • ✅ (pkg/gcs) test for IssueDownloadSignedURL
Property Value
Corresponding Issue #83
Assignee @Shion1305

PRで実装される機能

GCSのファイルに対してアクセスを付与する際は、Download用のSignedURLを発行する。
GCSパッケージに対してSignedURLの発行機能を実装。

レビューをお願いしたいポイント

#85 でGCSパッケージのベースはほぼ実装されていたみたい。

@Shion1305 Shion1305 linked an issue May 26, 2024 that may be closed by this pull request
GCSパッケージの作成 (pkg/gcs) #83
Open
2 tasks
@Shion1305 Shion1305 self-assigned this May 26, 2024
@Shion1305 Shion1305 marked this pull request as draft May 26, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Shion1305 Shion1305

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCSパッケージの作成 (pkg/gcs)
1 participant
@Shion1305