Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add job monitor for SLURM #40

Merged
merged 5 commits into from
Apr 10, 2024
Merged

add job monitor for SLURM #40

merged 5 commits into from
Apr 10, 2024

Conversation

brendanf
Copy link
Contributor

Prework

Related GitHub issues and pull requests

Summary

Implements job monitor class for SLURM, based on the existing SGE monitor. Tests in tests/slurm/monitor.R passed on my SLURM cluster (after appropriate modifications to script_lines).

Copy link
Owner

@wlandau wlandau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thank you so much for writing and testing this SLURM monitor! I only have one minor request (documented inline).

R/crew_monitor_slurm.R Show resolved Hide resolved
@wlandau
Copy link
Owner

wlandau commented Feb 29, 2024

Also, feel free to add yourself as an author or contributor in the DESCRIPTION file

@wlandau wlandau merged commit 3082d40 into wlandau:main Apr 10, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants