Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handles one-to-one, instead of merely unique #116

Closed
wants to merge 4 commits into from

Conversation

DUOLabs333
Copy link
Contributor

This fixes a bug where getcwd returns ENOENT.

This fixes a bug where getcwd returns ENOENT.
@willscott
Copy link
Owner

I'm tempted to just add the invalidate to the interface rather than also the update? It looks like invalidation should be enough to implement the updating of handles if potentially slightly less efficient.

@DUOLabs333
Copy link
Contributor Author

Yeah, it should be enough --- it's just that it's possible that a client (incorrectly) assumes that Rename does not invalidate handles, so we should be able to switch if needed.

@willscott
Copy link
Owner

if the client assumes the handle isn't invalidated it should get a stale handle error on it's next request and should then do an update, right?

We need to invalidate the old and new directories, is the main thing, right?

@DUOLabs333
Copy link
Contributor Author

DUOLabs333 commented Dec 29, 2023

  1. It should, yes (in theory).

  2. Only the old filename.

@DUOLabs333
Copy link
Contributor Author

I think you're right --- I'll remove the Update method after testing it (I didn't test this specific PR --- I based it off of a simpler POC that I did test).

@DUOLabs333
Copy link
Contributor Author

Ok, tested the code, and removed the UpdateHandle method.

@DUOLabs333 DUOLabs333 closed this Jan 1, 2024
@DUOLabs333 DUOLabs333 deleted the patch-2 branch January 1, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants