Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow implementations to support a custom comparison function. #106

Closed
wants to merge 2 commits into from

Conversation

DUOLabs333
Copy link
Contributor

No description provided.

@willscott
Copy link
Owner

would it be okay to check if fs.Stat('/') == fs2.Stat('/') as a way of seeing if they're the same filesystem?

@willscott
Copy link
Owner

would 828ed72 be sufficient? - i guess maybe would also be worthwhile to compare that the billy.Capabilities() of the two filesystems are the same

@DUOLabs333
Copy link
Contributor Author

Now I get comparing uncomparable type main.OverlayStat (this is because in order to fix some inode validation issue with my implementation, I have to add the filesystem as an attribute).

@willscott
Copy link
Owner

I'm okay doing this with c33eb6b

@DUOLabs333
Copy link
Contributor Author

Can we use DeepEqual on fs and fs2 directly? Alternatively, I was thinking that we can compare the pointer values of the two filesystems.

@willscott
Copy link
Owner

Can we use DeepEqual on fs and fs2 directly?

yes, that was my intention of what I was showing - the commit diff is confusing. https://github.com/willscott/go-nfs/compare/fix/onrename-fs is better

@DUOLabs333
Copy link
Contributor Author

Ok, with the commit, Rename no longer crashes (it doesn't look like it returns the wrong thing).

@willscott
Copy link
Owner

closed in favor of #114

@willscott willscott closed this Dec 26, 2023
@DUOLabs333 DUOLabs333 deleted the patch-1 branch December 29, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants