[TEAM REVIEW] WV 505 On the Ready Page, Update Tab order (UI Accessibility) - John Mook #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github.com/wevote/WebApp/issues does this fix?
https://wevoteusa.atlassian.net/browse/WV-505
Changes included this pull request?
In BallotElectionListWithFilters and FooterMainWeVote:
-changes non-semantic clickable divs to semantic buttons
In ReadyFinePrint:
-adds context and tabIndex to IntroHeader to have a spot for the tab to land when contentUnfurled becomes true
In ReadyIntroduction:
-adds context and tabIndex to IntroHeader to have a spot for the tab to land when contentUnfurled becomes true
-add button around span to make Enter Your Address semantic
In ShowMoreButtons:
-changes non-semantic clickable div to semantic button
In Ready page:
-changes order of elements to make tab flow from Follow Popular Topics to WeVote Helps You