WV-360 Scrolling Arrows #3993
Merged
WV-360 Scrolling Arrows #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Succorro I was happy to see that you have captured the most recent changes to OfficeItemCompressed in this pull request. Thank you! I would like to merge this ASAP, but currently I'm seeing big spaces above and below the BallotScrollingContainer in tablet modes (iPad Air for example). As soon as you can fix that, we can merge and work on the fine tuning. Thank you! |
|
I'll take a look at it as soon as I can and push the changes. |
|
Thank you Steven! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github.com/wevote/WebApp/issues does this fix?
Integrated side scrolling arrows for individual ballot items, fixed state handling issues derived from lack of individual component state management for rendered items.
Changes included this pull request?
Created new component (BallotScrollingContainer), transferred functionality from one file to another and created new logic to handle scrolling state.