update-wv-107-frontend TEAM REVIEW #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| @@ -19,7 +20,7 @@ function createSelect () { | |||
| // "[('AK', 'Alaska'), ('AL', 'Alabama'), ('AR', 'Arkansas') | |||
| const regex = /(\(.*?\))/gm; | |||
| const matches = Array.from(stateListString.matchAll(regex)); | |||
| let selectComponent = "<span>Select a state: <select id='state_code' name='state_code'>"; | |||
| let selectComponent = "<span style='display: inline-block;'>Select a state: <select id='state_code' name='state_code'>"; | |||
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| const match = matches[i][1]; | ||
| const selected = ''; | ||
| if (match === 'PUBLIC_SCHOOLS') { | ||
| checkboxComponent += `<input type='checkbox' id='${match}' name='source_code' value='${match}' ${selected} />Public Schools `; |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| if (match === 'PUBLIC_SCHOOLS') { | ||
| checkboxComponent += `<input type='checkbox' id='${match}' name='source_code' value='${match}' ${selected} />Public Schools `; | ||
| } else if (match === 'POST_OFFICE_LAT_LONG') { | ||
| checkboxComponent += `<input type='checkbox' id='${match}' name='source_code' value='${match}' ${selected} />Post Offices `; |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
|
Great work @pbnjcub 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github.com/wevote/WebApp/issues does this fix?
WV-107
Changes included this pull request?
code to create checkboxes to filter by source code on map view