dtls: fix race condition in DTLSConn::close #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #611 +/- ##
==========================================
- Coverage 60.59% 60.57% -0.03%
==========================================
Files 482 471 -11
Lines 47981 47937 -44
Branches 12478 12478
==========================================
- Hits 29075 29038 -37
+ Misses 9665 9638 -27
- Partials 9241 9261 +20 ☔ View full report in Codecov by Sentry. |
a context switch to a simultaneous close operation between `closed.load()` and `closed.store()` would lead to an additional unwanted close operation on the inner connection
|
please fix cargo clippy/fmt check. Thanks. |
looks like that is unrelated to this PR |
rainliu
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a context switch to a simultaneous close operation between
closed.load()andclosed.store()would lead to an additional unwanted close operation on the inner connection