Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update config instructions for v0.33.0 #218

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

gabrielmer
Copy link
Contributor

Updating config instructions for release v0.33.0

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-waku-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 2:16pm

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Maybe we should highlight more the Depricated signal.

@gabrielmer
Copy link
Contributor Author

LGTM! Maybe we should highlight more the Depricated signal.

Great idea, thank you! Changed the markdown to have the "Deprecated!" in bold. I see that in the theme of the docs website bold is not used and it gets automatically converted to uppercase letters but it's still more noticeable than without the change

Copy link
Contributor

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for it! 💯

@gabrielmer gabrielmer merged commit 35c06b3 into develop Sep 20, 2024
3 checks passed
@gabrielmer gabrielmer deleted the chore-update-config-instructions-for-v0.33.0 branch September 20, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants