Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial sensei configuration #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

litch
Copy link

@litch litch commented Apr 22, 2022

This requires a homegrown docker container that is not quite ready to be published yet, but getting close.

@litch litch changed the title Initial sensei configuration (requires local Sensei Docker container … Initial sensei configuration [WIP] Apr 22, 2022
@@ -108,7 +108,7 @@ services:
environment:
API_URL: http://localhost:3000
ports:
- 5000:5000
- 4400:5000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert to default ports (you can edit this on your data directory and/or soon via ENV variable #145 )

ports:
- "5401:5401"
- "3100:3000"
- "3001:3001"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will conflict to Liquid port

@tiero
Copy link
Member

tiero commented Apr 22, 2022

quite ready to be published yet

An image should be publicly available wither Docker Hub or Github Packages to be able to merge this for the public

@litch
Copy link
Author

litch commented Apr 22, 2022

Thansk for the heads up on the port thing. We've got a lot of ports going on here, so I'll ensure that.

And yes, I'll make sure a docker hub or github packages is available. Honestly I had meant to PR this to master of my own fork rather than here until I had it a little further along, but here it is. Oops.

Thanks for responding so quickly to the issues we were opening this morning!

@litch
Copy link
Author

litch commented May 6, 2022

Ok, this currently works as-is.

@litch litch changed the title Initial sensei configuration [WIP] Initial sensei configuration May 6, 2022
@@ -119,7 +119,7 @@ services:
environment:
API_URL: http://localhost:3001
ports:
- 5001:5000
- 4401:5000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, this is used in many tutorials already. Best to give a different one to new services introduced if possible

@@ -53,6 +53,8 @@ func startAction(ctx *cli.Context) error {
servicesToRun = append(servicesToRun, "lnd")
// Core Lightning Network
servicesToRun = append(servicesToRun, "lightningd")
// Sensei
servicesToRun = append(servicesToRun, "sensei")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Sensei capable to work without the frontend ie. only API/RPC? If Yes, may be worth running it also in CI mode (ie. under the isCI branch) so the Nigiri Github Action can offer CI testing using sensei

https://github.com/vulpemventures/nigiri-github-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants