Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other versions of remi repo on redhat #669

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kobybr
Copy link

@kobybr kobybr commented Oct 5, 2022

Currently the class php::repo::redhat is hardcoded to create only the remi56 repo. This request removes that static value and creates based on $yum_repo. This allows for other versions such as remi_php72, etc..

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I added some in-line comments for some points of attention and the docstrings need updating. Thanks!

manifests/repo/redhat.pp Outdated Show resolved Hide resolved
manifests/repo/redhat.pp Outdated Show resolved Hide resolved
manifests/repo/redhat.pp Outdated Show resolved Hide resolved
@kobybr kobybr requested a review from smortex October 8, 2022 13:53
@kobybr
Copy link
Author

kobybr commented Nov 21, 2022

Just checking in on this. Seems I have all the pieces in place, let me know otherwise.

Thanks

@farlerac
Copy link

Just checking in, are there any more issues we need to address with this PR?

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I missed the notification. Just a minor hitch.

@@ -13,6 +13,7 @@
/(?i:Amazon)/ => '6',
default => '$releasever', # Yum var
}
$version = $yum_repo.match('.\d$')[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.\d$ feels weird: any char followed by a digit at the end of a line.

I guess what you mean here is any number of digits at the end of the string? \d+\z

@smortex smortex added enhancement New feature or request and removed backwards-incompatible labels May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants