Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters for file/directory modes #134

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Conversation

ludovicus3
Copy link
Contributor

Some security scans don't like the default file modes set by this module. I have added parameters to allow for the adjustment of the file modes for this ability to resolve this issue per the users desires.

@TheMeier
Copy link
Contributor

Please update REFERENCE.md see https://voxpupuli.org/docs/how_to_run_tests/#referencemd-update

@TheMeier
Copy link
Contributor

IMHO it should only be file_mode and dir_mode

@ludovicus3
Copy link
Contributor Author

I don't have any major argument against that other than parameters that refer to the crontab and such are prefixed crontab_ but I could change it if it's preferred.

@TheMeier
Copy link
Contributor

Well what triggerd this comment is that the crontab-prefixed parameters seem to go inside the templated content opposed to any other parameters

@TheMeier
Copy link
Contributor

Ok an excception is crontab_run_parts which is used in the puppet DSL and in the epp

@TheMeier TheMeier merged commit f52edc0 into voxpupuli:master Jun 14, 2024
14 checks passed
@bastelfreak bastelfreak added the enhancement New feature or request label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants