Stop dumping GAM to stdout when reading >1k BED or GFF records #4363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
Description
In ae44fca @jmonlong improved memory usage when converting large BED and GFF files to GAM, by adding points at which we flush the output buffer. But when I merged #4248 I didn't notice that that buffer isn't always an output buffer and is sometimes an internal collection of annotations to work with later.
So whenever we tried to load and keep a lot of annotations, we would dump them out in GAM chunks of 1000 records each and throw them away, whenever we hit 1000 loaded records.
This fixes that.