Use more appropriate interface for detecting when XO api changes are …

…complete

client/client.go

@@ -256,6 +256,10 @@ func (c *Client) Call(method string, params, result interface{}, opt ...jsonrpc2
 	return nil
 }
 
+type RefreshComparison interface {
+	Propagated(obj interface{}) bool
+}
+
 type XoObject interface {
 	Compare(obj interface{}) bool
 }

client/network.go

@@ -60,7 +60,7 @@ type CreateNetworkRequest struct {
 
 // Nbd and Automatic are eventually consistent. This ensures that waitForModifyNetwork will
 // poll until the values are correct.
-func (c CreateNetworkRequest) Compare(obj interface{}) bool {
+func (c CreateNetworkRequest) Propagated(obj interface{}) bool {
 	otherNet := obj.(Network)
 
 	if otherNet.Automatic == c.Automatic &&
@@ -81,7 +81,7 @@ type UpdateNetworkRequest struct {
 
 // Nbd and Automatic are eventually consistent. This ensures that waitForModifyNetwork will
 // poll until the values are correct.
-func (c UpdateNetworkRequest) Compare(obj interface{}) bool {
+func (c UpdateNetworkRequest) Propagated(obj interface{}) bool {
 	otherNet := obj.(Network)
 
 	if otherNet.Automatic == c.Automatic &&
@@ -119,15 +119,15 @@ func (c *Client) CreateNetwork(netReq CreateNetworkRequest) (*Network, error) {
 	return c.waitForModifyNetwork(id, netReq, 10*time.Second)
 }
 
-func (c *Client) waitForModifyNetwork(id string, target XoObject, timeout time.Duration) (*Network, error) {
+func (c *Client) waitForModifyNetwork(id string, target RefreshComparison, timeout time.Duration) (*Network, error) {
 	refreshFn := func() (result interface{}, state string, err error) {
 		network, err := c.GetNetwork(Network{Id: id})
 
 		if err != nil {
 			return network, "", err
 		}
 
-		equal := strconv.FormatBool(target.Compare(*network))
+		equal := strconv.FormatBool(target.Propagated(*network))
 
 		return network, equal, nil
 	}