Skip to content

Latest commit

 

History

History
81 lines (60 loc) · 4.64 KB

review.md

File metadata and controls

81 lines (60 loc) · 4.64 KB

 


 home   |   syllabus   |   groups   |   moodle   |   video   |   review   |   © 2022


Review

(presented in reverse chronological order)

Format of exams:

X vs y

  1. What is the same
  2. What is different
  3. When to pick X or Y
  4. How to check if you pick turns out to be not working

All Review Questions

HW1

image

Grade=1

rand Grade Comment
0.052 1 please add "data/" and "test/" directories
0.061 1 Missing contribution.md, missing requirement.txt (based on your language)
0.141 1 I see you have build and test badges, as well as build and test actions. But there are not connected, the badge will always display passing even when they are not. Please fix.
0.284 1 please change the source directory name to "src", and add a setup.py file
0.312 1 I was not able to find your automated test case running. While I see the badge it needs to link to your tests that run every commit. I see you are using travis, link to your travis test build report
0.318 1 "Your README.md does not have any badges aside the minimal ones. Also, badges usually go on the top of the readme. Please fix.
0.372 1 Please generate a Release and add a DOI badge (with Zenodo) for your release
0.376 1 Your README.md needs work. You do not have a fitting description of the project. Please fix.
0.400 1 missing: CITATION.md, INSTALL.md. Also please generate a DOI badge (with Zenodo)
0.462 1 missing: DOI badge, CITATION.md
0.470 1 missing badges, missing test cases,
0.648 1 Your README.md does not have any badges aside the minimal ones. Please fix.
0.683 1 In general it's best to have code / test in different directories on the root. Also please generate a Release and a DOI link (with Zenodo) for your release
0.689 1 missing: DOI badge, CITATION.md
0.730 1 "Your INSTALL.md is empty, and I have given you an incomplete. You may re-submit. I recommend you add at least pytest to requirements.txt
0.743 1 "Your README.md is barebones. You do not have any description at all of the project, nor any badges aside from the minimally requested ones. Please fix.
0.781 1 "Your README.md is barebones. You do not have any description at all of the project, nor any badges aside from the minimally requested ones. Please fix.
0.781 1 please add "data/" directory and change the source directory name to "src"
0.882 1 missing: build:passing and please add a directory data/
0.948 1 "Your README.md is barebones. You do not have any description at all of the project, nor any badges aside from the minimally requested ones. Please fix.
0.956 1 (1) please change the source directory name to "src" (2) why are DB secrets committed?

Grade=2

rand Grade Comment
0.095 2 you probably don't need an init.py file at the root
0.133 2 Please change your build passing badge to point to your github actions link
0.194 2 Please change your build passing badge to point to your github actions link
0.245 2 Could have some extra bling (Think more badges showing what language/framework you are using) A badge for License etc
0.295 2 (1) please change the source directory name to "src" (2) ditch the .DS_Store (3) you don't need .travis.yml if you're using GitHub actions, you won't lose points
0.416 2 please change the source directory name to "src"
0.541 2 (1) please change the source directory name to "src" (2) your test directory describes tests that don't exist yet
0.649 2 Please change your build passing badge to point to your github actions link
0.880 2 please change the source directory name to "src"
0.886 2 please change the source directory name to "src"; does your test dir need an init.py file to run?
0.935 2 please change the source directory name to "src"